Skip to content

BSL036 — Usage of complex expressions in the "If" condition

← All rules

Summary

Usage of complex expressions in the "If" condition

Identifiers

Field Value
Rule code BSL036
Compatible alias IfConditionComplexity
Severity WARNING
Enabled by default Yes
Implemented Yes
Tags brain-overload, complexity

Behavior

  • The public identifier BSL036 and alias IfConditionComplexity are stable.
  • The rule reports the cases documented on this page.
  • Suppressions and project configuration are applied before publication.
  • The rule requires neither an external analyzer nor network access.

Configuration and suppression

BSL### is the primary stable identifier. The compatible alias is accepted in select, ignore, and compatible block suppression comments.

[tool.onec-hbk-bsl]
select = ["BSL036"]
ignore = ["IfConditionComplexity"]

All three suppression families support both a current line and a range. When an opening comment follows code, it affects only that line. Use any one form:

  • noqa:
Value = "example";  // noqa: BSL036
  • bsl-disable:
Value = "example";  // bsl-disable: BSL036
  • compatible BSLLS form:
Value = "example";  // BSLLS:IfConditionComplexity-off

When the same opening comment is on a line by itself, it starts a range. Close it with the matching marker from the same family:

// noqa: BSL036
// code without this diagnostic
// noqa-enable: BSL036

// bsl-disable: BSL036
// code without this diagnostic
// bsl-enable: BSL036

// BSLLS:IfConditionComplexity-off
// code without this diagnostic
// BSLLS:IfConditionComplexity-on

To disable the rule until the end of the file, omit the closing noqa-enable, bsl-enable, or BSLLS:…-on marker.

Opening and closing markers must belong to the same family.

Description

Complex expressions (with more than 3 boolean constructs) must be extracted to separated method or variable.

Examples

Bad:

If Id = "Expr1"
    Or Id = "Expr2"
    Or Id = "Expr3"
    Or Id = "Expr4"
    Or Id = "Expr5"
    Or Id = "Expr6"
    Or Id = "Expr7"
    Or Id = "Expr8"
    Or Id = "Expr9" Then

   doSomeWork();

EndIf;

Good:

If IsCorrectId(Id) Then
   doSomeWork();
КонецЕсли;

Function IsCorrectId(Id)

    Return Id = "Expr1"
            Or Id = "Expr2"
            Or Id = "Expr3"
            Or Id = "Expr4"
            Or Id = "Expr5"
            Or Id = "Expr6"
            Or Id = "Expr7"
            Or Id = "Expr8"
            Or Id = "Expr9";

EndFunction