Skip to content

BSL263 - Useless collection iteration

Summary

Useless collection iteration

Identifiers

Field Value
Rule code BSL263
Compatible alias UseLessForEach
Severity WARNING
Without configuration Yes
BSLLS JSON, ON mode without overrides Yes
Registry flag implemented Yes
Tags redundant, suspicious

The implemented flag describes the registry; it does not certify verified BSLLS parity.

Behavior

  • The public identifier BSL263 and alias UseLessForEach are stable.
  • The rule reports the cases documented on this page.
  • Suppressions and project configuration are applied before publication.
  • The rule requires neither an external analyzer nor network access.

Configuration and suppression

BSL### is the primary stable identifier. The compatible alias is accepted in select, ignore, and compatible block suppression comments.

[tool.onec-hbk-bsl]
select = ["BSL263"]
ignore = ["UseLessForEach"]

All three suppression families support both a current line and a range. When an opening comment follows code, it affects only that line. Use any one form:

  • noqa:
Value = "example";  // noqa: BSL263
  • bsl-disable:
Value = "example";  // bsl-disable: BSL263
  • compatible BSLLS form:
Value = "example";  // BSLLS:UseLessForEach-off

When the same opening comment is on a line by itself, it starts a range. Close it with the matching marker from the same family:

// noqa: BSL263
// code without this diagnostic
// noqa-enable: BSL263

// bsl-disable: BSL263
// code without this diagnostic
// bsl-enable: BSL263

// BSLLS:UseLessForEach-off
// code without this diagnostic
// BSLLS:UseLessForEach-on

To disable the rule until the end of the file, omit the closing noqa-enable, bsl-enable, or BSLLS:…-on marker.

Opening and closing markers must belong to the same family.

Description

The absence of an iterator in the loop body indicates either a useless iteration of the collection or an error in the loop body.

Examples

Incorrect:

For Each Iterator From Collection Loop

    ProcessElement(Collection);

EndLoop;

Correct

For Each Iterator From Collection Loop

    ProcessElement(Iterator);

EndLoop;
ProcessCollection(Collection);