Skip to content

BSL223 — Nested constructors with parameters in structure declaration

← All rules

Summary

Nested constructors with parameters in structure declaration

Identifiers

Field Value
Rule code BSL223
Compatible alias NestedConstructorsInStructureDeclaration
Severity INFORMATION
Enabled by default Yes
Implemented Yes
Tags readability, design

Behavior

  • The public identifier BSL223 and alias NestedConstructorsInStructureDeclaration are stable.
  • The rule reports the cases documented on this page.
  • Suppressions and project configuration are applied before publication.
  • The rule requires neither an external analyzer nor network access.

Configuration and suppression

BSL### is the primary stable identifier. The compatible alias is accepted in select, ignore, and compatible block suppression comments.

[tool.onec-hbk-bsl]
select = ["BSL223"]
ignore = ["NestedConstructorsInStructureDeclaration"]

All three suppression families support both a current line and a range. When an opening comment follows code, it affects only that line. Use any one form:

  • noqa:
Value = "example";  // noqa: BSL223
  • bsl-disable:
Value = "example";  // bsl-disable: BSL223
  • compatible BSLLS form:
Value = "example";  // BSLLS:NestedConstructorsInStructureDeclaration-off

When the same opening comment is on a line by itself, it starts a range. Close it with the matching marker from the same family:

// noqa: BSL223
// code without this diagnostic
// noqa-enable: BSL223

// bsl-disable: BSL223
// code without this diagnostic
// bsl-enable: BSL223

// BSLLS:NestedConstructorsInStructureDeclaration-off
// code without this diagnostic
// BSLLS:NestedConstructorsInStructureDeclaration-on

To disable the rule until the end of the file, omit the closing noqa-enable, bsl-enable, or BSLLS:…-on marker.

Opening and closing markers must belong to the same family.

Description

It is not recommended to use constructors of other objects in the structure constructor if these constructors accept parameters. In particular, in the constructor of one structure it is not recommended to create other structures with the declaration of property values.

Examples

Incorrect

GoodsServer.MakeGoods(
  Object.Products,
  New Structure(
  "CharacteristicsUsed,
  |Type, Variant",
   New Structure("Good", "CharacteristicsUsed"),
   New Structure("Good", "Type"),
   New Structure("Good", "Variant")
  )
 );

Correct

Parameters = New Structure;
Parameters.Вставить("CharacteristicsUsed", New Structure("Good", "CharacteristicsUsed"));
Parameters.Вставить("Type",                New Structure("Good", "Type"));
Parameters.Вставить("Variant",             New Structure("Good", "Variant"));
GoodsServer.MakeGoods(Object.Products,     Parameters);