Skip to content

BSL230 — Violation of pairing using methods "BeginTransaction()" & "CommitTransaction()" / "RollbackTransaction()"

Summary

Violation of pairing using methods "BeginTransaction()" & "CommitTransaction()" / "RollbackTransaction()"

Identifiers

Field Value
Rule code BSL230
Compatible alias PairingBrokenTransaction
Severity ERROR
Enabled by default Yes
Implemented Yes
Tags transaction, correctness

Behavior

  • The public identifier BSL230 and alias PairingBrokenTransaction are stable.
  • The rule reports the cases documented on this page.
  • Suppressions and project configuration are applied before publication.
  • The rule requires neither an external analyzer nor network access.

Configuration and suppression

BSL### is the primary stable identifier. The compatible alias is accepted in select, ignore, and compatible block suppression comments.

[tool.onec-hbk-bsl]
select = ["BSL230"]
ignore = ["PairingBrokenTransaction"]

All three suppression families support both a current line and a range. When an opening comment follows code, it affects only that line. Use any one form:

  • noqa:
Value = "example";  // noqa: BSL230
  • bsl-disable:
Value = "example";  // bsl-disable: BSL230
  • compatible BSLLS form:
Value = "example";  // BSLLS:PairingBrokenTransaction-off

When the same opening comment is on a line by itself, it starts a range. Close it with the matching marker from the same family:

// noqa: BSL230
// code without this diagnostic
// noqa-enable: BSL230

// bsl-disable: BSL230
// code without this diagnostic
// bsl-enable: BSL230

// BSLLS:PairingBrokenTransaction-off
// code without this diagnostic
// BSLLS:PairingBrokenTransaction-on

To disable the rule until the end of the file, omit the closing noqa-enable, bsl-enable, or BSLLS:…-on marker.

Opening and closing markers must belong to the same family.

Description

Beginning of transaction and it's committing (rollback) have to be executed withing context of the same method.

Examples

Correct

Procedure WriteDataToIB()

    StartTransaction();

    Try
        ... // read or write data
        DocumentObject.Write()
        CommitTransaction();
    Raise
        RollbackTransaction();
        ... // additional steps to handle the exception
    EndTry;

EndProcedure

Incorrect

Procedure WriteDataToIB()

    StartTransaction();
    WriteDocument();

EndProcedure;

Procedure WriteDocument()

    Try
        ... // read or write data
        DocumentObject.Write()
        CommitTransaction();
    Raise
        RollbackTransaction();
        ... // additional steps to handle the exception
    EndTry;

EndProcedure

Sources