Skip to content

BSL224 — Initialization of method and constructor parameters by calling nested methods

← All rules

Summary

Initialization of method and constructor parameters by calling nested methods

Identifiers

Field Value
Rule code BSL224
Compatible alias NestedFunctionInParameters
Severity INFORMATION
Enabled by default Yes
Implemented Yes
Tags readability, brain-overload

Behavior

  • The public identifier BSL224 and alias NestedFunctionInParameters are stable.
  • The rule reports the cases documented on this page.
  • Suppressions and project configuration are applied before publication.
  • The rule requires neither an external analyzer nor network access.

Configuration and suppression

BSL### is the primary stable identifier. The compatible alias is accepted in select, ignore, and compatible block suppression comments.

[tool.onec-hbk-bsl]
select = ["BSL224"]
ignore = ["NestedFunctionInParameters"]

All three suppression families support both a current line and a range. When an opening comment follows code, it affects only that line. Use any one form:

  • noqa:
Value = "example";  // noqa: BSL224
  • bsl-disable:
Value = "example";  // bsl-disable: BSL224
  • compatible BSLLS form:
Value = "example";  // BSLLS:NestedFunctionInParameters-off

When the same opening comment is on a line by itself, it starts a range. Close it with the matching marker from the same family:

// noqa: BSL224
// code without this diagnostic
// noqa-enable: BSL224

// bsl-disable: BSL224
// code without this diagnostic
// bsl-enable: BSL224

// BSLLS:NestedFunctionInParameters-off
// code without this diagnostic
// BSLLS:NestedFunctionInParameters-on

To disable the rule until the end of the file, omit the closing noqa-enable, bsl-enable, or BSLLS:…-on marker.

Opening and closing markers must belong to the same family.

Description

Similarly, it is not recommended to use nested calls of other functions or other parameterized constructors when initializing constructor parameters .

At the same time, if the code with nested calls is compact (does not require the hyphenation of expressions) and is easy to read, then nested calls are acceptable.

Examples

Incorrect:

Attachments.Insert(  AttachedFile.Description,  New Picture(GetFromTempStorage(   AttachedFiles.GetFileData(AttachedFile.Ref).RefToFileBinaryData)));

It is correct to break such calls into separate operators using additional local variables:

FileImageHRef = AttachedFiles.GetFileData(AttachedFile.Ref).RefToFileBinaryData; PictureData = New Picture(GetFromTempStorage(FileImageHRef)); Attachments.Insert(AttachedFile.Description, PictureData);

Sources